ec2system: changes for environments other than GRAIL #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusae
reviewed
Oct 11, 2019
machine.go
Outdated
| @@ -333,10 +333,13 @@ func (m *Machine) loop(ctx context.Context, system System) { | |||
| log.Error.Printf("Keepalive %v: %v", m.Addr, err) | |||
| } | |||
| cancel() | |||
| log.Printf("Cancelled....") | |||
machine.go
Outdated
| @@ -536,6 +539,7 @@ func (m *Machine) exec(ctx context.Context) error { | |||
| } | |||
|
|
|||
| func (m *Machine) call(ctx context.Context, serviceMethod string, arg, reply interface{}) (err error) { | |||
| log.Printf(">>>>>> calling: %v", serviceMethod) | |||
|
other than the debug printfs, do the changes seem reasonable to you? |
|
If so, I'll clean it up and resend. |
|
Yep, seems good to me
…On Fri, Oct 11, 2019 at 10:44 AM Cosmos Nicolaou ***@***.***> wrote:
If so, I'll clean it up and resend.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#7?email_source=notifications&email_token=AAAH22FNPCJV5ADIQD4P253QOC3QVA5CNFSM4I7V4OEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBAW5QI#issuecomment-541159105>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAH22EC5IC3XIRDLGX2QFDQOC3QVANCNFSM4I7V4OEA>
.
--
This email message, including attachments, may contain private,
proprietary, or privileged information and is the confidential information
and/or property of GRAIL, Inc., and is for the sole use of the intended
recipient(s). Any unauthorized review, use, disclosure or distribution is
strictly prohibited. If you are not the intended recipient, please contact
the sender by reply email and destroy all copies of the original message.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the configurability of ec2 instances to allow for configurations other than GRAIL's.