Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert for when a plugin is being used for a version, of Grails/Java that's not supported #10195

Closed
virtualdogbert opened this issue Sep 30, 2016 · 6 comments
Closed

Alert for when a plugin is being used for a version, of Grails/Java that's not supported #10195

virtualdogbert opened this issue Sep 30, 2016 · 6 comments
Assignees
@benrhine
Labels
type: improvement
Milestone
grails-3.3.10

Comments

@virtualdogbert
Copy link

I would be nice to have a feature where a plug-in developer could specify a min/max version of Grails/Java. Then when a user tries to use that plug-in with a version of Grails/Java, that is not supported they would get and error/warning message.
@virtualdogbert virtualdogbert changed the title Altert for when a plugin is being used for a version, of Groovy/Java that's not supported Alert for when a plugin is being used for a version, of Groovy/Java that's not supported Sep 30, 2016
@graemerocher
Copy link
Member

This is already possible, see grailsVersion property at http://docs.grails.org/latest/guide/plugins.html#creatingAndInstallingPlugins

@osscontributor
Copy link
Member

The title says "Groovy/Java" but the body says "Grails/Java". Dealing with Java and Groovy version issues is separate from dealing with Grails versions. I think the grailsVersion property should deal with the Grails version.

@virtualdogbert virtualdogbert changed the title Alert for when a plugin is being used for a version, of Groovy/Java that's not supported Alert for when a plugin is being used for a version, of Grails/Java that's not supported Sep 30, 2016
@osscontributor
Copy link
Member

I see the title has been changed now so the issue isn't concerned with Groovy versions. That leaves Grails and Java. I believe that grailsVersion deals with the Grails version. Allowing plugin authors to express a Java version would be a new feature. If a plugin requires a certain version of Java, they could deal with that in the same way that any Java library could. We could conceivably add explicit support for specifying Java versions but I don't think it is needed.

Thoughts?

@virtualdogbert
Copy link
Author

The Java version was something someone else brought up on slack. I'm using Java 8, so it's not really a big deal for me, right now. Not sure about the future with Java 9...

With the Grails version, you're right there is a place to specify the version, but when you try to compile or run the app, there is no warning, or error message, indicating the incompatibility.

@osscontributor
Copy link
Member

With the Grails version, you're right there is a place to specify the version, but when you try to compile or run the app, there is no warning, or error message, indicating the incompatibility.

Will get that straightened out. Thanks for the feedback.

@osscontributor
Copy link
Member

Never mind the title and description of this issue. We will treat this as relating only to Grails version and not relating to Java versions.

@rpalcolea rpalcolea mentioned this issue Oct 11, 2016
Open
@jameskleeh jameskleeh added this to the grails-3.3.9 milestone Nov 1, 2018
@ilopmar ilopmar modified the milestones: grails-3.3.9, grails-3.3.10 Dec 4, 2018
@ilopmar ilopmar closed this as completed Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benrhine benrhine

Labels
type: improvement
Projects
None yet
Milestone
grails-3.3.10
Development

No branches or pull requests
7 participants
@osscontributor @graemerocher @virtualdogbert @ilopmar @jameskleeh @benrhine and others