Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the old grails-shell project #13399

Closed
puneetbehl opened this issue Feb 27, 2024 · 5 comments · Fixed by #13407
Closed

Deprecate the old grails-shell project #13399

puneetbehl opened this issue Feb 27, 2024 · 5 comments · Fixed by #13407
Assignees

Comments

@puneetbehl
Copy link
Contributor

Issue description

Starting Grails 6, we have introduction the new CLI. So, we would need to deprecate the grails-shell subproject or extract it out from grails-core.

@guillermocalvo
Copy link
Contributor

@puneetbehl Grails Profile Gradle Plugin still depends greatly on grails-shell. I tried moving classes under org.grails.cli.profile from grails-shell to grails-gradle-plugin, but those classes depend on other packages that are unrelated to profiles, so I don't think it would be a clean move.

Is Grails Profile Gradle Plugin still relevant? In other words, can we deprecate it along with grails-shell, or do we need to keep maintaining it for the foreseeable future?

@puneetbehl
Copy link
Contributor Author

Yes, I think it is not used any longer. Since Grails 6, we stopped using/creating Grails profiles. The plugin is used for distribution of Grails Profile. Also, there is GrailsProfilePublishPlugin which may also be removed.

@guillermocalvo
Copy link
Contributor

Yes, I think it is not used any longer. Since Grails 6, we stopped using/creating Grails profiles. The plugin is used for distribution of Grails Profile. Also, there is GrailsProfilePublishPlugin which may also be removed.

Thanks for the info! I created a PR to remove those legacy plugins from grails-gradle-plugin.

I looked into possible Grails projects that may still depend on the deprecated CLI and found several repositories. Most of them seem obsolete, but I'd like to know your opinion before we remove grails-shell from grails-core.

  1. grails-profile-repository
  2. grails-profiles
    • You mentioned that Grails profiles are not used anymore, so I guess we can ignore all repositories under grails-profiles that still depend on grails-shell.
  3. grails-wrapper
  4. legacy-grails-doc
    • Although this repository has recent commits, I think we can ignore it too. I guess there may be some scheduled job that pushes changes periodically.
  5. grails-database-migration

So what do you think about all these legacy repositories @puneetbehl? Would it be possible to archive them in GitHub to make them read-only and indicate that they are no longer maintained?

@puneetbehl
Copy link
Contributor Author

The legacy-grails-doc is created to surpass GitHub limit for publishing the Grails documentation on gh-pages. So, extracted the older version docs to a different repository.

I am also not so sure about how Grails Database Migration plugin depends on grails-shell. It would be good to investigate the need.

For the rest of these, I believe it is safe to archive them.

@guillermocalvo
Copy link
Contributor

Important

@puneetbehl Please take a look at this PR: grails/grails-database-migration#350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants