Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support set springBootVersion in Gradle #105

Closed

Conversation

rainboyan
Copy link
Contributor

Fixed issue #104:

Update in gradle.properties will apply new version of Spring Boot

Use managed dependency versions that are provided by Spring Boot

spring-framework.version=5.3.19
mysql.version=8.0.28

Update  in gradle.properties will apply new version of Spring Boot

Use managed dependency versions that are provided by Spring Boot
Copy link
Contributor Author

@rainboyan rainboyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@puneetbehl please review this feature.

@puneetbehl
Copy link
Contributor

I think we should allow changing spring version for Grails application. It should be tied to Grails version. Otherwise, it may create a lot of confusions and errors. I am trying to figure out an alternative to decouple this from Grails Gradle Plugin.

@rainboyan
Copy link
Contributor Author

@puneetbehl thank you for your time.

I think we should allow changing spring version for Grails application.

Currently, we can change spring version via spring.version. but if the changed version is very low or high than the version tied to Grails version, there also will be errors.
This PR allow change spring boot version, we also can check the version, just allow PATCH version. If there are incompatible changes, there may be the issues of Spring Boot or 3rd frameworks. For example, spring framework v5.3.18, logback v1.2.9, Spring boot and Grails users could change the version to upgrade or downgrade, it's always up to the users.

I am trying to figure out an alternative to decouple this from Grails Gradle Plugin.

Spring Boot Gradle Plugin is always published with Spring Boot, so can Grails. Maybe we should back the old days. Grails could be released a week later than Spring Boot, and patch releases are released once a month.

@rainboyan
Copy link
Contributor Author

rainboyan commented Jul 1, 2022

@puneetbehl if grails-shell could contains grails-bom.xml in jar file, so grails-grade-plugin could read it and get the versions of Groovy, Micronaut, Spring Boot, this will keep the version same as Grails.
I have test this in my fork rainboyan@e2fedad rainboyan/GoBoots@1d26e15, it works.

but in the build.gradle of app, we must include grails-shell in the classpath, because grails-gradle-plugin may use an old version.

buildscript {
    repositories {
        maven { url "https://repo.grails.org/grails/core" }
    }
    dependencies {
        classpath "org.grails:grails-gradle-plugin:$grailsGradlePluginVersion"
        classpath "org.grails:grails-shell:$grailsVersion"
        classpath "org.grails.plugins:hibernate5:7.2.2"
    }
}

@rainboyan rainboyan closed this Sep 9, 2022
@rainboyan rainboyan deleted the support_update_spring_boot_version branch September 9, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants