feat!: Update libbinaryen to v105 #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
force-pushed
the
phated/libbinaryen_105
branch
2 times, most recently
from
f18d443
to
8807ea4
Compare
phated
force-pushed
the
phated/libbinaryen_105
branch
from
23d88f2
to
ae7a71d
Compare
|
@ospencer this is ready for review! |
ospencer
reviewed
Mar 16, 2022
| @@ -98,6 +98,7 @@ caml_binaryen_element_segment_get_name(value _elem) { | |||
| CAMLreturn(caml_copy_string(BinaryenElementSegmentGetName(elem))); | |||
| } | |||
|
|
|||
| // TODO: Expose to bindings | |||
There was a problem hiding this comment.
Can't do it now because the JS version doesn't actually expose this at all! I was so happy to find that we didn't implement it 😅
ospencer
approved these changes
Mar 16, 2022
There was a problem hiding this comment.
This looks great! When I initially looked this over, all of the implementations looked reasonable/correct, though of course the eyes tend to start glazing over after a certain point. I didn't see any obvious mistakes, so let's ship it! Do you think it's possible to run the Grain test suite in JS? It sounds possible but feels difficult 😛
|
I can give it a try with this new JSOO structure! But let's get this merged first. I'll try it before releasing the new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #104
Once completed, this will update the underlying libbinaryen to v105.1.0 and switch out the virtual module for more standard js_of_ocaml externals.
This was a beast of an undertaking, so the review will probably take a while.