Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Provide binaryen.js with library #48

Merged
merged 5 commits into from Mar 9, 2022
Merged

feat: Provide binaryen.js with library #48

merged 5 commits into from Mar 9, 2022

Conversation

phated
Copy link
Member

@phated phated commented Mar 8, 2022

This bundles binaryen.js (compiled by hand via emscripten) with into this project. We'll then be able to write js_of_ocaml externals in binaryen.ml instead while relying on the same library.

Closes #18

@phated phated requested a review from ospencer March 8, 2022 22:08
Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very handy!

@phated phated force-pushed the phated/provide-js branch 2 times, most recently from eaefbe5 to 8412b89 Compare March 9, 2022 01:09
@phated phated merged commit f389527 into main Mar 9, 2022
@phated phated deleted the phated/provide-js branch March 9, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there a way for us to bundle binaryen.js with this?
2 participants