feat!: Update binaryen to version_108 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore!: Change js_of_ocaml binding to Binaryen
ospencer
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #59
This upgrades the project to version_108 of binaryen. This is the version that has our JS_OF_OCAML flag, so I also implemented the CI workflow to generate the JS file. The reason dune doesn't build it on demand is because we need emsdk to build the JS version and I don't want to force that upon people.
This did introduce a slight chicken-egg problem in that the JS file is generated at a different time as the rest of CI and so any changes aren't available to the esy or opam workflows. I could combine them if we think it is better, but I don't foresee this library changing much now that everything we needed was upstreamed. @ospencer do you have an opinion?