Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Upgrade to libbinaryen v111 #75

Merged
merged 5 commits into from Feb 7, 2023
Merged

feat!: Upgrade to libbinaryen v111 #75

merged 5 commits into from Feb 7, 2023

Conversation

phated
Copy link
Member

@phated phated commented Feb 6, 2023

This updates the project to provide binaryen version_111.

It also adds a gcc 10 job in CI to verify that the maybe-uninitialized flag isn't needed anymore. (You can see it failed when I applied it to main: https://github.com/grain-lang/libbinaryen/actions/runs/4098969417/jobs/7068455768)

I also dug into the other flag and found that we need it because esy ships gcc7 with mingw.

@phated phated requested a review from ospencer February 6, 2023 01:49
Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@phated phated merged commit e43a7ff into main Feb 7, 2023
@phated phated deleted the phated/binaryen_111 branch February 7, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants