Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grunt needs to be run for npm release #1

Open
benwiley4000 opened this issue May 5, 2016 · 2 comments
Open

Grunt needs to be run for npm release #1

benwiley4000 opened this issue May 5, 2016 · 2 comments

Comments

@benwiley4000
Copy link

benwiley4000 commented May 5, 2016

The original module is bad for npm since it specifies an AMD module name, which must match the name of the npm package, or else. Since the npm module is called pace-progress, and the AMD module is called pace, a bundler like browserify or webpack won't be able to resolve the dependency.

Removing that from the coffeescript file was great, but I had to run Grunt on my own fork to get it working; the built javascript files still specify an AMD module name.

Thanks 😃

@graingert
Copy link
Owner

@benwiley4000 ah ok makes sense. I'm using pace-progress in production with require('imports?define=>false!pace-progress') so yes looks like that's the fix.

@gebrial
Copy link

gebrial commented May 28, 2019

I have made a a pull request for a permanent fix but in the meantime a temporary fix for this issue for webpack can be found here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants