-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up RNN branch #13
Comments
With poetry we probably want to make the rnn dependencies optional, as they are quite heavy (mainly tensorflow). |
I manually updated pyproject.toml adding the rnn dependencies. For the versions I checked what the latest was and used that, but that might not be necessary. Then ran |
It runs now, as long as the data is present at |
Another todo: generate the documentation, and probably for that to work we have to pick one convention for docstrings as currently we're using different ones. |
We picked the following convention for docstrings:
|
Regarding the dependencies, In this commit I created two groups of extras rnn and rnn_M1_macOS with the necessary dependencies (only difference is in tensorflow). |
The installation of tensorflow for arm64 macOS requires some extra steps that cannot be handled from poetry. I think the best is to keep it separately: if an user has M1 macOS he/she will have to install tensorflow first on his own, and then he/she can install grainLearning on the same python environment. |
The text was updated successfully, but these errors were encountered: