[Workbase] - Implicit relationship bug #2956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 15, 2018 12:21
Irtazaraza
changed the title
marco-scoppetta
suggested changes
Aug 15, 2018
| @@ -106,7 +109,7 @@ const methods = { | |||
| if (!concepts.length) { | |||
| this.$notifyInfo('No results were found for your query!', 'bottom-right'); | |||
| } | |||
| return { nodes: await ManagementUtils.prepareNodes(concepts), edges: [] }; | |||
| return ManagementUtils.filterImplicitTypes(concepts); | |||
There was a problem hiding this comment.
is there a reason why we don't filter out implicit nodes right after const concepts = await this.exectueQuery(query);?
| return Promise.all(concepts.map(async (concept) => { | ||
| if (concept.isThing()) { | ||
| return (!await (await concept.type()).isImplicit()) ? concept : null; | ||
| } |
There was a problem hiding this comment.
should we also filter out implicit schema concepts? just to be more consistent,
so maybe just add:
if (concept.isSchemConcept()) {
return !await concept.isImplicit() ? concept : null;
}
or maybe there is a reason why we are not doing it - I am just wondering
| await prepareRelationship(thing); | ||
| break; | ||
| default: | ||
| // do nothing |
There was a problem hiding this comment.
throw "Unrecognised baseType of thing ["+thing.baseType+"]" we should never get anything that is not entity/rel/attribute - if we ever do let's throw exception so that these things don't go unnoticed
| expect(concepts).toHaveLength(1); | ||
| concepts = await DataManagementUtils.filterImplicitTypes(concepts); | ||
| expect(concepts).toHaveLength(0); | ||
| }); |
There was a problem hiding this comment.
YAAAYY testssss 👍 💯
added 2 commits
August 15, 2018 15:15
marco-scoppetta
approved these changes
Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR needed?
Implicit relationships were being loaded to the graph
What does the PR do?
Filter outs all implicit types
Does it break backwards compatibility?
No
List of future improvements not on this PR
No