Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise Exception on username not found or at least handle it better #39

Closed
philip-ulrich opened this issue Nov 13, 2020 · 1 comment
Closed
Labels
enhancement New feature or request
Milestone

Comments

@philip-ulrich
Copy link
Contributor

I think we should raise an exception on this issue and not let the user continue. The reason being that it's not tracking any of the actions done and it leads to bad situations where users may have been followed by the script, but not tracked. Forcing a user to "unfollow any" in order to remove them - or do it manually. I can't think of any valid reasons why we would continue if we can't get their username.

If we do want to continue, we should at least safe it to an "undefined" user or something so that data isn't lost.

Ref: https://github.com/GramAddict/bot/blob/master/GramAddict/core/storage.py#L27

Thoughts?

@arthurspa arthurspa added the enhancement New feature or request label Nov 19, 2020
@philip-ulrich philip-ulrich added this to the v1.0.6 milestone Nov 28, 2020
@philip-ulrich
Copy link
Contributor Author

We already do. Turns out I already thought of this during the refactor?

https://github.com/GramAddict/bot/blame/f1548e7ffb088b7bfa88919b9c326bbeaa0d75e2/GramAddict/__init__.py#L218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants