You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When rebuilding faust 2.30.5 against llvm 12 I noticed, that architecture/faust/gui/JSONUI.h lacks an include for <limits>.
This has apparently already been fixed in 81683c5#diff-25b34ad466346be9b12ce5135b2266d68566cafe4bd1949f4e714d3b41dcc7e5. However, this small change to fix the build of faust is done in a commit that introduces a large set of other unrelated changes. It would be great if these changes could be introduced in smaller commits (e.g. one to only fix this particular issue), as those would apply cleanly downstream, without backporting or introducing potentially undesired behavior.
The text was updated successfully, but these errors were encountered:
When rebuilding faust 2.30.5 against llvm 12 I noticed, that
architecture/faust/gui/JSONUI.h
lacks an include for<limits>
.This has apparently already been fixed in 81683c5#diff-25b34ad466346be9b12ce5135b2266d68566cafe4bd1949f4e714d3b41dcc7e5. However, this small change to fix the build of faust is done in a commit that introduces a large set of other unrelated changes. It would be great if these changes could be introduced in smaller commits (e.g. one to only fix this particular issue), as those would apply cleanly downstream, without backporting or introducing potentially undesired behavior.
The text was updated successfully, but these errors were encountered: