Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing include for limits, but commit introduces too many changes #586

Closed
dvzrv opened this issue May 29, 2021 · 1 comment
Closed

Missing include for limits, but commit introduces too many changes #586

dvzrv opened this issue May 29, 2021 · 1 comment

Comments

@dvzrv
Copy link
Contributor

dvzrv commented May 29, 2021

When rebuilding faust 2.30.5 against llvm 12 I noticed, that architecture/faust/gui/JSONUI.h lacks an include for <limits>.

This has apparently already been fixed in 81683c5#diff-25b34ad466346be9b12ce5135b2266d68566cafe4bd1949f4e714d3b41dcc7e5. However, this small change to fix the build of faust is done in a commit that introduces a large set of other unrelated changes. It would be great if these changes could be introduced in smaller commits (e.g. one to only fix this particular issue), as those would apply cleanly downstream, without backporting or introducing potentially undesired behavior.

@sletz
Copy link
Member

sletz commented May 29, 2021

Sure... but thinking as each consequence of each commit can start to be quite cumbersome.

@sletz sletz closed this as completed May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants