Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installs empty directory /usr/local/share/examples/guidolib/new-tags-v1.51/symbols #130

Closed
yurivict opened this issue Oct 24, 2021 · 5 comments

Comments

@yurivict
Copy link
Contributor

No description provided.

@dfober
Copy link
Member

dfober commented Oct 25, 2021

I don't have any '.../share/examples/guidolib/new-tags-v1.51' folder installed, but .../share/guidolib/examples/new-tags-v1.51 is installed and it's not empty. (checked on an Ubuntu 20.04)

@yurivict
Copy link
Contributor Author

yurivict commented Oct 25, 2021

The folder is altered to match the FreeBSD port's examples directory:

-       set (INSTALL_SAMPLES    ${CMAKE_INSTALL_PREFIX}/share/guidolib/examples)
+       set (INSTALL_SAMPLES    share/examples/guidolib)

and /usr/local/share/examples/guidolib/new-tags-v1.51/symbols/ is installed empty.

The cmake install instruction has FILES_MATCHING PATTERN "*.gmn" which causes the *png files to be ignored. You probably use an older cmake version. I use cmake-3.21.3.

@dfober
Copy link
Member

dfober commented Oct 26, 2021

Sorry but this files organization seems not to be shared by all distributions and I don't want to cope with dist specificities.

and /usr/local/share/examples/guidolib/new-tags-v1.51/symbols/ is installed empty.

don't know where this folder comes from... as mentioned before: share/guidolib/examples/new-tags-v1.51 is installed and it's not empty

@yurivict
Copy link
Contributor Author

This folder is installed by the cmake install target in build/CMakeLists.txt.

This patch helps:

--- build/CMakeLists.txt.orig   2021-10-25 09:44:31 UTC
+++ build/CMakeLists.txt
@@ -319,7 +319,7 @@ install (
        DIRECTORY ${GMN} DESTINATION ${INSTALL_SAMPLES}
        FILE_PERMISSIONS OWNER_READ OWNER_WRITE GROUP_READ WORLD_READ
        DIRECTORY_PERMISSIONS OWNER_READ OWNER_WRITE OWNER_EXECUTE GROUP_READ GROUP_EXECUTE WORLD_READ WORLD_EXECUTE
-       FILES_MATCHING PATTERN "*.gmn"
+       #FILES_MATCHING PATTERN "*.gmn" # workaround for https://github.com/grame-cncm/guidolib/issues/130
        PATTERN "SheetMusic" EXCLUDE
 )

@dfober
Copy link
Member

dfober commented Oct 27, 2021

that's done

@dfober dfober closed this as completed Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants