Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy navigation #6

Closed
KnorpelSenf opened this issue Oct 10, 2021 · 0 comments · Fixed by #10
Closed

Lazy navigation #6

KnorpelSenf opened this issue Oct 10, 2021 · 0 comments · Fixed by #10

Comments

@KnorpelSenf
Copy link
Member

KnorpelSenf commented Oct 10, 2021

See

menu/src/menu.ts

Lines 747 to 753 in c2e3571

// TODO: do not update menu immediately!
// Instead, only set a flag that the menu must be updated. Then,
// wait for calls that edit the same message, and inject the
// payload there. This will both prevent flickering and save an
// API call. If no such call is performed, fall back to
// performing an extra API call.

We want to perform menu updates lazily. This prevents both flickering and is more efficient.

Can be disabled by passing { immediate: true } to ctx.menu.update.

@KnorpelSenf KnorpelSenf mentioned this issue Oct 11, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant