Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with negative values in sim2root #69

Closed
jelenakhlr opened this issue Oct 27, 2023 · 2 comments
Closed

Problem with negative values in sim2root #69

jelenakhlr opened this issue Oct 27, 2023 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed sim2root

Comments

@jelenakhlr
Copy link
Member

sim2root seems to dislike negative values, but it needs to be able to handle them


Traceback (most recent call last):
File "/home/grand/sim2root/CoREASRawRoot/../Common/sim2root.py", line 383, in
main()
File "/home/grand/sim2root/CoREASRawRoot/../Common/sim2root.py", line 75, in main
rawefield2grandroot(trawefield, gt)
File "/home/grand/sim2root/CoREASRawRoot/../Common/sim2root.py", line 361, in rawefield2grandroot
gt.tefield.du_seconds=tempseconds
File "/home/grand/grand/dataio/root_trees.py", line 186, in set
inst += value
File "/home/grand/grand/dataio/root_trees.py", line 133, in iadd
if self.ndim == 1: value = array.array(cpp_to_array_typecodes[self.basic_vec_type], value)
OverflowError: can't convert negative value to unsigned int
Traceback (most recent call last):
File "/home/grand/sim2root/CoREASRawRoot/coreas_pipeline.py", line 70, in
subprocess.run(sim2root, check=True)
File "/usr/lib64/python3.10/subprocess.py", line 526, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['python3', '../Common/sim2root.py', 'Coreas_006100.root']' returned non-zero exit status 1.

@jelenakhlr jelenakhlr added the bug Something isn't working label Oct 27, 2023
@jelenakhlr
Copy link
Member Author

See commit b417c59 on dev_io_root - I might have fixed the issue, but it would be good if someone could double check
@mjtueros @lwpiotr

@jelenakhlr jelenakhlr added help wanted Extra attention is needed sim2root labels Oct 27, 2023
@mjtueros
Copy link
Contributor

this looks to be working now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed sim2root
Projects
None yet
Development

No branches or pull requests

2 participants