This repository has been archived by the owner on Mar 16, 2021. It is now read-only.
Convert thirtyinch module tests to Kotlin #174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terTest and TestPresenterExampleTest to kotlin
|
The build before updating the gradle plugin was failing because of not finishing download of gradle plugin. |
This reverts commit 642fd61.
|
You have to update the travis.yml file too |
|
Ok, I think we can do it in a separate PR. |
This was referenced Dec 26, 2018
|
As discussed in a conversation with @passsy the library is pretty stable right now and at this moment there is no need to convert the source code (especially tests) to Kotlin. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Kotlin support to
thirtyinchmodule tests.As a start, converts
TiTestPresenterTestandTestPresenterExampleTestto Kotlin and MockK.