Compatibility fixes #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Got the project working with both 0.x and 1.x versions of the 'cuke_modeler' gem.
Added gemfiles for testing against both major versions of the 'cuke_modeler' gem and configured the continuous integration process to run against both of them.
Declaring a dependency that was being used but not included in the gemspec.
Locked down a dependency version for Ruby 1.x.
Locked down another dependency version for Ruby 1.x.
Locked down one more dependency version for Ruby 1.x.
Removing some gemfile configuration that is no longer needed now that the CI process uses dedicated gemfiles.
|
Changes Unknown when pulling 9bf0dfb on enkessler:compatibility_fixes into * on grange-insurance:master*. |
|
Looks good to me. Bump it to 2.0.1! |
|
FYI, @ashtony42 @dbwest @jmflatt: I'll be including this project in a presentation that I will be giving later this week. People may come here looking for a working version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All fixed up. Build is passing again.