fix(input): added input validation to throw descriptive errors

Fix #40
grantila · Aug 27, 2019 · bc8f1de · bc8f1de
1 parent 578f21b
commit bc8f1de
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 7 deletions.
diff --git a/lib/index.js b/lib/index.js
diff --git a/src/index.js b/src/index.js
@@ -136,6 +136,11 @@ function PhoneNumber( phoneNumber, regionCode )
 
 	let parsed;
 
+	if ( !isInternal && typeof phoneNumber !== 'string' )
+		throw new Error( "Invalid phone number, expected a string" );
+	if ( !isInternal && regionCode != null && typeof regionCode !== 'string' )
+		throw new Error( "Invalid region code, expected a string" );
+
 	if ( !isInternal )
 	{
 		if ( regionCode && ( phoneNumber.charAt( 0 ) === '+' ) )

diff --git a/test.in/awesome-phonenumber/should-compile.ts b/test.in/awesome-phonenumber/should-compile.ts
@@ -146,4 +146,23 @@ describe( 'errors', function( ) {
 		expect( pn.isPossible( ) ).to.be.false;
 		expect( pn.toJSON( ).possibility ).to.equal( 'too-short' );
 	} );
+
+	it( 'should handle invalid phone number', function( ) {
+		const failure = ( arg: any ) => ( ) => new PhoneNumber( arg );
+
+		expect( failure( null ) ).to.throw( "Invalid phone number" );
+		expect( failure( { } ) ).to.throw( "Invalid phone number" );
+		expect( failure( [ ] ) ).to.throw( "Invalid phone number" );
+		expect( failure( 5 ) ).to.throw( "Invalid phone number" );
+		expect( failure( true ) ).to.throw( "Invalid phone number" );
+	} );
+
+	it( 'should handle invalid phone number', function( ) {
+		const failure = ( arg: any ) => ( ) => new PhoneNumber( '987654321', arg );
+
+		expect( failure( { } ) ).to.throw( "Invalid region code" );
+		expect( failure( [ ] ) ).to.throw( "Invalid region code" );
+		expect( failure( 5 ) ).to.throw( "Invalid region code" );
+		expect( failure( true ) ).to.throw( "Invalid region code" );
+	} );
 } );