compatibility with marginaleffects 0.9.0 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merci @vincentarelbundock. Appreciate the heads-up and the proactive fix! Quick question before I merge: Have you submitted to CRAN yet? |
|
Yes, it's already submitted. Sorry this is so quick. I was pushed to submit by a revdep issue of my own, and didn't think about I'm not used to having people depend on my packages, but I'll try to have a revdep workflow on Github actions so we have more forewarning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the trouble, but version 0.9.0 of
marginaleffectswill breaketwfe. Unfortunately, this means that you will receive an email asking you to upload a new version to CRAN very soon.This PR fixes all compatibility issues I could notice, and makes the tests slightly more resilient to future issues.
One recommendation: avoid using the column name "group" as in
test_baker.R. This is a "reserved" word inmarginaleffects; I will build some guardrails in the future, but for now this is dangerous.