Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support lwd argument #134

Merged
merged 57 commits into from
Mar 9, 2024
Merged

Support lwd argument #134

merged 57 commits into from
Mar 9, 2024

Conversation

grantmcdermott
Copy link
Owner

@grantmcdermott grantmcdermott commented Mar 9, 2024 •
edited

Closes #120.

MWE:

pkgload::load_all("~/Documents/Projects/tinyplot/")
#> ℹ Loading tinyplot

plt(mpg ~ wt | factor(cyl), mtcars, type = "b", lwd = "by")

Created on 2024-03-08 with reprex v2.1.0

grantmcdermott and others added 30 commits February 10, 2024 18:20
@grantmcdermott
working prototype for continuous legend
ddd21fd
@grantmcdermott
Adjust old test
a98cb8b
@grantmcdermott
Document legend.ugc behaviour
61fc776
@grantmcdermott
switch to rasterImage gradient swatch
25d46fd
@grantmcdermott
typo
0706843
@grantmcdermott
close #124
7cf6de7
@grantmcdermott
Fix inner gradient legend placement
64fb1b9
@grantmcdermott
Update example
a093b86
@grantmcdermott
Merge branch 'main' into continuous-legend
8431eb7
@grantmcdermott
Fix check failures after main merge
914e474
@grantmcdermott
Catch if bg = "by" and col is atomic
75bed77
@grantmcdermott
Add tests
7f37a19
@grantmcdermott
Clean up internal code and comments
c157e1f
@grantmcdermott
Consistent snake_case
c72f5f1
@grantmcdermott
NEWS and version bump
8bc2317
@grantmcdermott
Update README and vignette
c39cc00
@grantmcdermott
fix badge
8a1fa0b
@grantmcdermott @etiennebacher
Update NEWS.md
794ad95 
Co-authored-by: Etienne Bacher <52219252+etiennebacher@users.noreply.github.com>
@grantmcdermott
fix label alignment
0a56194
@grantmcdermott
better lab positioning still
ac70f45
@grantmcdermott
fix bg = scalar bug caught by Achim
e48cd4d
@grantmcdermott
Another part of the previous bug fix
1680dfc
@grantmcdermott
catch for ordered factors
c38981a
@grantmcdermott
update tests
9be47a9
@grantmcdermott
add bg scalar test
3ec53eb
@grantmcdermott
Remove legend.ugc logic
02c4453 
- So long and thanks for all the fish!
@grantmcdermott
Use adjusted viridis palette as default for gradient legend
2a8c256
@grantmcdermott
Update tests following new gradient palette default
35a47ef
@grantmcdermott
Minor test tweak
c7956e8
@grantmcdermott
Re-run README examples
223dd28
grantmcdermott and others added 27 commits February 22, 2024 09:55
@grantmcdermott
Update docs
dcdda8a
@grantmcdermott
tweak
a7085be
@grantmcdermott
Update vignette
1ae3e2f
@grantmcdermott
Fix namespace note
4b46844
@grantmcdermott
Fix R CMD note
ca683d8
@grantmcdermott
Thanks Achim in NEWS
243a8ee
@grantmcdermott
Close #130
29096a6 
(Actually done earlier in c38981a, but adding news item now)
@grantmcdermott
wording tweak
6a68cde
@grantmcdermott
Interpolate gradient colors if necessary
4836c20
@grantmcdermott
Ensure correct reverse order for gradient if user supplies n = 100 cols
3ff92fe
@grantmcdermott
Use restricted (and reversed) viridis default palette for ordered fac…
23acb74 
…tors too
@grantmcdermott
minor doc update
78b1bbe
@grantmcdermott
color interpolation should respect alpha channel
6de6c12
@grantmcdermott
Basic lwd support
79f2888
@grantmcdermott
Merge branch 'main' into lwd
39b592e
@grantmcdermott
update readme figure from main too
6ca4c94
@grantmcdermott
better catch for 'p'
d5797d8
@grantmcdermott
Merge in main
0554c51
@grantmcdermott
Fix
69affcc
@grantmcdermott
lwd catches for other types
f21380d
@grantmcdermott
incidental update for tests
3c5443b
@grantmcdermott
Tweak by_lwd logic
61aea45
@grantmcdermott
Update / add lwd to by_aesthestics tests
f128a5a
@grantmcdermott
NEWS and version bump
b4891cd
@grantmcdermott
Catch for direct draw_legend calls
b5b05ee
@grantmcdermott
Docs
aff1207
@grantmcdermott
typos
f8c2f70
@grantmcdermott grantmcdermott merged commit b907d2d into main Mar 9, 2024
3 checks passed
@grantmcdermott grantmcdermott deleted the lwd branch March 16, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support lwd argument
1 participant
@grantmcdermott