plot2.formula now does proper formula parsing via stats::model.frame #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address issue #3, I have implemented now a proper formula parsing for
plot2.formula
:y ~ x | z
is simply converted toy ~ x + z
.stats::model.frame()
is called "as usual" withsubset
,na.action
, anddrop.unused.levels
.y
, the second asx
, and all others (if any) are collapsed to a single factor. Either viaas.factor()
(for a single variable) orinteraction()
(if more than one variable).Open question: Many arguments of
plot2.formula()
are actually not used at all inplot2.formula()
but only passed on toplot2.default()
. If these arguments have defaults that are identical between the two methods, the argument could also be omitted fromplot2.formula()
. If needed it is passed through...
.