Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using usize for ids is incorrect. #8

Open
JNissi opened this issue Sep 1, 2023 · 1 comment
Open

Using usize for ids is incorrect. #8

JNissi opened this issue Sep 1, 2023 · 1 comment

Comments

@JNissi
Copy link

JNissi commented Sep 1, 2023

Both the place_id and osm_id can be quite a bit larger than u32. When run on a target with 32bit usize (wasm in this case) parsing the responses starts panicking at these ids.

Please consider changing the integer ids to u64 instead of usize.

@JNissi
Copy link
Author

JNissi commented Sep 1, 2023

I'm in the middle of something and don't have the time to submit a PR right now, but probably can in a few weeks. There's some other wasm-related changes too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant