-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reroute to dashboard if there is only one budget #8
Conversation
Add a tap operator in the effect to fetch budgets data to reroute to the dashboard if there is only one budget.
Your Render PR Server URL is https://ynab-custom-reports-pr-8.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cojhn5uv3ddc73eta2d0. |
Your Render PR Server URL is https://ynab-custom-reports-pr-8.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cosoufed3nmc73bdbcf0. |
Your Render PR Server URL is https://ynab-custom-reports-pr-8.onrender.com/. Follow its progress at https://dashboard.render.com/static/srv-cojhn5uv3ddc73eta2d0. |
Your Render PR Server URL is https://ynab-custom-reports-pr-8.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cosp17u3e1ms73d8k55g. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
==========================================
+ Coverage 96.74% 96.81% +0.06%
==========================================
Files 20 20
Lines 246 251 +5
Branches 19 20 +1
==========================================
+ Hits 238 243 +5
Misses 5 5
Partials 3 3 ☔ View full report in Codecov by Sentry. |
Your Render PR Server URL is https://ynab-custom-reports-pr-8.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cosp23mg1b2c73fhm4tg. |
Your Render PR Server URL is https://ynab-custom-reports-pr-8.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cosp46779t8c73f0gp9g. |
Your Render PR Server URL is https://ynab-custom-reports-pr-8.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cosp796d3nmc73bdbkj0. |
Your Render PR Server URL is https://ynab-custom-reports-pr-8.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cosp9ri1hbls73csh2ig. |
Your Render PR Server URL is https://ynab-custom-reports-pr-8.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-couimfvjbltc73akv2t0. |
Your Render PR Server URL is https://ynab-custom-reports-pr-8.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-couj2u4f7o1s73e5mqsg. |
Your Render PR Server URL is https://ynab-custom-reports-pr-8.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-couj92m3e1ms73f22a4g. |
Your Render PR Server URL is https://ynab-custom-reports-pr-8.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-couja8v109ks73e59ea0. |
Your Render PR Server URL is https://ynab-custom-reports-pr-8.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-coujb80l6cac73a9vfdg. |
Your Render PR Server URL is https://ynab-custom-reports-pr-8.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-coujcm6ct0pc73adub2g. |
Your Render PR Server URL is https://ynab-custom-reports-pr-8.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-coujfumn7f5s738qv3og. |
This was open and closed a bunch to test out the lighthouse report functionality |
Add a tap operator in the effect to fetch budgets data to reroute to the dashboard if there is only one budget.
Pull Request Template
Title
[Provide a succinct and descriptive title for the pull request, e.g., "Improve caching mechanism for API calls"]
Type of Change
Description
[Provide a detailed explanation of the changes you have made. Include the reasons behind these changes and any relevant context. Link any related issues. For UI/UX changes, include a screenshot or recording of the changes.]
Testing
[Detail the testing you have performed to ensure that these changes function as intended. Include information about any added tests.]
Impact
[Discuss the impact of your changes on the project. This might include effects on performance, new dependencies, or changes in behavior.]
Additional Information
[Any additional information that reviewers should be aware of.]
Checklist