Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reroute to dashboard if there is only one budget #8

Closed
wants to merge 7 commits into from

Conversation

grantwforsythe
Copy link
Owner

Add a tap operator in the effect to fetch budgets data to reroute to the dashboard if there is only one budget.

Pull Request Template

Title

[Provide a succinct and descriptive title for the pull request, e.g., "Improve caching mechanism for API calls"]

Type of Change

  • Feature
  • Fix
  • Refactor
  • UI/UX improvement

Description

[Provide a detailed explanation of the changes you have made. Include the reasons behind these changes and any relevant context. Link any related issues. For UI/UX changes, include a screenshot or recording of the changes.]

Testing

[Detail the testing you have performed to ensure that these changes function as intended. Include information about any added tests.]

Impact

[Discuss the impact of your changes on the project. This might include effects on performance, new dependencies, or changes in behavior.]

Additional Information

[Any additional information that reviewers should be aware of.]

Checklist

  • My code adheres to the coding and style guidelines of the project as specified in CONTRIBUTING.md.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

Add a tap operator in the effect to fetch budgets data to reroute to the
dashboard if there is only one budget.
Copy link

render bot commented Apr 23, 2024

@grantwforsythe grantwforsythe added the enhancement New feature or request label Apr 23, 2024
@grantwforsythe grantwforsythe reopened this May 7, 2024
Copy link

render bot commented May 7, 2024

@grantwforsythe
Copy link
Owner Author

Copy link

render bot commented May 7, 2024

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.81%. Comparing base (b247ab3) to head (f60fd64).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   96.74%   96.81%   +0.06%     
==========================================
  Files          20       20              
  Lines         246      251       +5     
  Branches       19       20       +1     
==========================================
+ Hits          238      243       +5     
  Misses          5        5              
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

render bot commented May 7, 2024

Copy link

render bot commented May 7, 2024

Copy link

render bot commented May 7, 2024

Copy link

render bot commented May 7, 2024

@grantwforsythe grantwforsythe deleted the feat/mock-data branch May 7, 2024 03:02
@grantwforsythe grantwforsythe restored the feat/mock-data branch May 9, 2024 19:59
@grantwforsythe grantwforsythe reopened this May 9, 2024
Copy link

render bot commented May 9, 2024

Copy link

render bot commented May 9, 2024

Copy link

render bot commented May 9, 2024

Copy link

render bot commented May 9, 2024

Copy link

render bot commented May 9, 2024

Copy link

render bot commented May 9, 2024

Copy link

render bot commented May 9, 2024

@grantwforsythe
Copy link
Owner Author

grantwforsythe commented May 9, 2024

This was open and closed a bunch to test out the lighthouse report functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant