Support for node_modules in graphql imports

[lfades]

Before (manual search for node_modules folder):

# import Auth from '../../node_modules/module-name/auth.graphql'

Now:

# import Auth from 'module-name/auth.graphql'

[schickling]

Can you please rebase so I can merge?

Also, can you please add a test case for this? You might need to add another .gitignore file.

[lfades]

@schickling Sure, I'm working on it

[lfades]

@schickling How should be done the test case ? I can probably install a package as a dev dependency that has graphql files and import one of those, or can you see a better way ?

[schickling]

You can also "manually create" a node_modules folder + an example package in the corresponding test folder and explicitly allow it in the .gitignore. This way you don't need to install it as a dependency.

[lfades]

Tests added, please keep in mind that the following code will still not work:

importSchema('module-name/a.graphql')

It would introduce a breaking change

[schickling]

The tests still seem to fail. Can you look into it and fix it?

[lfades]

yep, checks for node are failing here

I already pushed that folder and tests are passing, do you have any idea of how can I replicate that behaviour ?

[SpaceK33z]

@lfades It might be possible the CI does something weird with caching node_modules. I suggest creating the graphql-import-test/b.graphql file before starting the relevant test, that way you are sure it is added. Also, this way the b.graphql file is not gone after you do rm -rf node_modules.

[lfades]

@SpaceK33z that makes a lot of sense, I'll add some fs code to the test 💃

[lfades]

@schickling I found some bad news about this PR, it only works in Node > 8, I already know the solution but I don't like it, so I want to share my thoughts with you first:

require.resolve is the main change done by this PR, the second param that it receives it's an object that has a paths option, which I use to make the import relative to the graphql file. The reason why it doesn't works in previous versions of node is because such option doesn't exists.

Possible solutions:

• By using internal code like the way eslint is doing it here, related to this issue. I don't personally like this solution because we'll lose types and we'll need to use internal methods e.g _.something, but is an option
• Only allow module imports in newest versions of node

[tamlyn]

The issue that lead to that feature being added to Node 8 lists a bunch of packages in the Prior Art section. resolve-from gets >5m downloads a week and would probably be a good choice.

[kitten]

@tamlyn This seems to be the way to go.

@lfades It'd be awesome to see this in graphql-import and if you'd need help to bring this PR up to speed, I'm offering myself as a tribute

cc @schickling any objections to using resolve-from or this PR being picked up again? Btw #4 should probably reopened as this PR addresses it

[lfades]

If resolve-from is okay I can finish this PR with it

[SpaceK33z]

Still very much looking forward to this feature. Perhaps just finish the PR with the resolve-from as it seems to be the only way? I can help if you don't have the time.

[lfades]

Closed in favor of #216