Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ch.force_heading and do not allow pass_through for node-based CH #1763

Closed
easbar opened this issue Oct 23, 2019 · 5 comments
Closed
Milestone

Comments

@easbar
Copy link
Member

easbar commented Oct 23, 2019

Heading and pass_through does not really work with node-based CH (even though there are cases where it works). Right now there is an extra ch.force_heading parameter that can be set to allow it anyway. Do we need to keep this ? Should pass_through not also be forbidden for node-based CH (unless ch.force_heading is set) ?

On the other hand supporting heading and pass_through for edge-based CH should be possible. Would be nice to have now that we have edge-based CH ?

@devemux86 ?

related: #1697, #1647, #1765

@devemux86
Copy link
Contributor

One of the reasons the flexible mode remains the preferred option in vehicle navigation is because it has features like heading (in degrees), besides the (previous) main benefit of turn restrictions.

If speed mode manages to have also the heading after turn restrictions, that would be awesome. 🙂

@easbar
Copy link
Member Author

easbar commented Oct 23, 2019

And are you currently using heading with speed mode (currently broken and requires ch.force_heading=true) ?

@devemux86
Copy link
Contributor

And are you currently using heading with speed mode (currently broken and requires ch.force_heading=true) ?

No, I use those features only with flexible mode.

@karussell
Copy link
Member

Do we need to keep this ?

No

Should pass_through not also be forbidden for node-based CH

Yes

Would be nice to have now that we have edge-based CH ?

Yes :)

@easbar easbar changed the title Remove ch.force_heading and do not allow pass_through for node-based CH ? Remove ch.force_heading and do not allow pass_through for node-based CH Oct 23, 2019
@easbar easbar closed this as completed in cfc9766 Dec 5, 2019
@easbar easbar added this to the 1.0 milestone Dec 5, 2019
@easbar
Copy link
Member Author

easbar commented Dec 5, 2019

For pass_through support with speed mode see #1765, for heading the best you can do atm is using edge-based CH with curbside parameters (see #1697). Sooner or later we should implement heading with edge-based CH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants