Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alternative route has detour for turn_costs=true #2101

Closed
karussell opened this issue Jul 29, 2020 · 1 comment
Closed

alternative route has detour for turn_costs=true #2101

karussell opened this issue Jul 29, 2020 · 1 comment
Assignees
Milestone

Comments

@karussell
Copy link
Member

karussell commented Jul 29, 2020

For this route there is a strange detour circle in the middle which disappears for turn_costs=false.

image

@karussell karussell changed the title alternative route detour if turn_costs=true alternative route has detour for turn_costs=true Jul 29, 2020
@michaz michaz self-assigned this Aug 12, 2020
@michaz
Copy link
Member

michaz commented Aug 12, 2020

Ahhh, right. We need to concatenate "edge-based paths" properly.

Suppose we have a non-shortest candidate path s----u-v-w----t. Now we want a concatenation of two shortest paths via v. In node-based search, we take concat(s->v, v->t). In edge-based, we were taking concat(s->u-v, v-w->t). But that can be an ugly path (see above), because maybe from v-w we need to get back via u-v again.

Instead, we want concat(s->u-v, u-v->t). Concatenating "by edge", of course. (Removing the duplicate u-v edge.)

@michaz michaz closed this as completed in f3d8bd5 Aug 12, 2020
@karussell karussell added this to the 2.0 milestone Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants