Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development mode warning printed when in test mode #2028

Closed
nwjsmith opened this issue Apr 19, 2024 · 2 comments
Closed

Development mode warning printed when in test mode #2028

nwjsmith opened this issue Apr 19, 2024 · 2 comments
Labels

Comments

@nwjsmith
Copy link

Summary

Steps to reproduce

Run GRAPHILE_ENV=test node -e 'require("postgraphile")' or NODE_ENV=test node -e 'require("postgraphile")'

Expected results

Since we're explicitly in test mode, I would expect to see no warnings meant to catch production deployments of Grafast's development mode.

Actual results

When running GRAPHILE_ENV=test node -e 'require("postgraphile")':

Grafast is running in development mode due to `GRAPHILE_ENV=test`; this is recommended for development environments (and strongly discouraged in production), but will impact on performance - in particular, planning will be significantly more expensive.

When running NODE_ENV=test node -e 'require("postgraphile")'

Grafast is running in development mode due to `NODE_ENV=test`; this is recommended for development environments (and strongly discouraged in production), but will impact on performance - in particular, planning will be significantly more expensive.

Additional context

Filed as suggested in the Discord forum.

@benjie
Copy link
Member

benjie commented May 7, 2024

Can confirm this was fixed in Feb (but currently unreleased): 4d9f83d

@benjie benjie closed this as completed May 7, 2024
@nwjsmith
Copy link
Author

nwjsmith commented May 8, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants