Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Views don't have primary keys #4

Closed
nbaum opened this issue Apr 27, 2016 · 3 comments
Closed

Views don't have primary keys #4

nbaum opened this issue Apr 27, 2016 · 3 comments

Comments

@nbaum
Copy link

nbaum commented Apr 27, 2016

Making a GraphML schema for a PG schema containing views fails because views don't have primary keys.
@calebmer
Copy link
Collaborator

Yeah this is a big deal. Didn't think about that, thanks.

I decided to error when tables didn't have primary keys so to enforce support for the Relay Node interface, but views don't necessarily need to implement Node. I'll fix this soon.

@nbaum nbaum changed the title Views don't have primary keys. Views don't have primary keys Apr 27, 2016
@calebmer
Copy link
Collaborator

calebmer commented Apr 27, 2016 •
edited

Fixed this in #10/1.1.0 if you want to try it out. I'll wait for feedback then close this issue.

Also, I've started a Gitter room if you want to talk about your experiences with PostGraphQL. Also, if you'd like to contribute I want to adopt an open-open source governance model so core collaborators have direct commit rights on the repo (only makes sense as PostGraphQL is definitely a critical dependency).

@calebmer
Copy link
Collaborator

Closing as this is fixed in 1.1.0 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nbaum @calebmer