feat(plugins): hook priority system #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjie
force-pushed
the
plugin-priorities
branch
from
312684e
to
b43da05
Compare
|
Oh, this does a topological sort on the registered hook functions, so that the order of plugins is becoming less relevant? Cool! |
|
It's not ready for that yet; it's still experimental. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff in this PR is massively misleading. Using
?w=1may help a little, but I recommend checking it out locally and using:That'll hide all whitespace differences, not just on a line-by-line basis.
This should not affect the existing hook order; but it does allow plugins to register hooks before other hooks.