Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): add PoolClient to pgConfig union type #425

Merged
merged 2 commits into from
Mar 21, 2019
Merged

fix(types): add PoolClient to pgConfig union type #425

merged 2 commits into from
Mar 21, 2019

Conversation

mattbretl
Copy link
Contributor

No description provided.

benjie
benjie requested changes Mar 21, 2019
View reviewed changes
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I think it should only be PoolClient/Pool - i.e. no Client. Ref: https://github.com/graphile/graphile-engine/blob/master/packages/graphile-build-pg/src/withPgClient.js#L56 (this might be a difference with Flow vs TypeScript typings for pg)

@mattbretl
Copy link
Contributor Author

Good catch. Fixed.

@benjie benjie merged commit 413ea16 into graphile:master Mar 21, 2019
@mattbretl mattbretl deleted the patch-1 branch August 27, 2019 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjie benjie benjie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattbretl @benjie