Add option hideIndexWarnings for ignoreIndexes: false

[tinymarsracing]

No description provided.

[tinymarsracing]

issue #461 and relates to graphile/crystal#942

[benjie]

You even got the naming conventions right; good job!

[benjie]

Just a tiny tweak, please :)

[benjie]

You need to run yarn prettier:fix and then it should be good to go 👍

[tinymarsracing]

Oh no. I was editing on github.com. :-D What would be the normal way to do this? git clone and then commit to the PR from the command line?

…

On Fri, 17 May 2019 at 17:52, Benjie Gillam ***@***.***> wrote: You need to run yarn prettier:fix and then it should be good to go 👍 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#462?email_source=notifications&email_token=AI5LUW6KMGFWC5W7NFTSP73PV3ICZA5CNFSM4HNVPFF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVVEMLI#issuecomment-493504045>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AI5LUW2PMDW6LWNBLUQMW3TPV3ICZANCNFSM4HNVPFFQ> .

-- Adrian Wenke LinkedIn <https://www.linkedin.com/in/adrian-wenke/> +49 177 1750789 Skype: adrian_wenke

[tinymarsracing]

I tried again, but it doesn't pass. Pretty sure there's no syntax errors. Are you sure it's not the entity._omitUnindexedReadWarningGiven = true; that needs to run?

[benjie]

You can leave it with me; the issue is prettier so easy for me to fix. From CI:

eslint packages && lerna run tslint
/home/travis/build/graphile/graphile-engine/packages/graphile-build-pg/src/plugins/PgBasicsPlugin.js
160:34 error Insert ⏎······· prettier/prettier
175:8 error Delete · prettier/prettier
✖ 2 problem

[tinymarsracing]

Hi @benjie, has this been merged/published yet?

[benjie]

Sorry for the delay; it's been incredibly hectic recently!

[tinymarsracing]

No worries, thank you.