Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get fieldName from scope, instead of field.name #489

Merged
merged 3 commits into from
Aug 6, 2019

Conversation

singingwolfboy
Copy link
Contributor

Follow up to #488. name is not a field on GraphQLFieldConfig (see the docs for graphql-js) so any reference to field.name returns undefined. Instead, we should use the fieldName from the scope object.

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing what seems to have been quite a prevalent copy/paste error 😳

@benjie benjie merged commit 122a612 into graphile:master Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants