feat(query): improve unique orderBy error message #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjie
requested changes
Aug 31, 2019
Co-Authored-By: Benjie Gillam <benjie@jemjie.com>
benjie
approved these changes
Aug 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the cursor for pagination (
beforeandafter) Graphile requires that theorderByclause must be composed by unique value, either referring the table PK or mixing values that returns a unique result.Currently when the query fails due to that error the message returned is
Cannot use cursors without orderBy, which is misleading, because there might be anorderByclause passed, but it's not correctly assigned.This PR uses a validation that already exists in the codebase and throws an error message based on the flag returned from it.