fix(utils): only apply condition when specified #572
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to allow
{allFoos(condition:{myCustomCondition: null}){...}}
to trigger the condition callback (and it's up to that how to handle the null); however if the condition was not specified (e.g.{allFoos(condition:{}){...}}
) then the callback should not be consulted.This is technically a breaking change, but this plugin is still marked as experimental, so it only counts as a fix in this case.