Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for
@enum
on views as well as tables. Required re-organizing of the logic, and previously we were relying on the fact that constraints aren't introspected except in the public schemas, but since views don't have constraints we've had to explicitly opt non-public tables out of enums (this should not cause any issues).Fixes graphile/crystal#1424.
Performance impact
Negligible.
Security impact
None known.