Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(order): fix order by computed column SQL item bug #741

Merged
merged 5 commits into from May 26, 2021

Conversation

pszafer
Copy link
Contributor

@pszafer pszafer commented May 14, 2021

Description

Issue: #740

Performance impact

Security impact

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
    Passes with multiple warning from different files.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

…on-delete.graphql

Co-authored-by: Benjie Gillam <benjie@jemjie.com>
@benjie
Copy link
Member

benjie commented May 24, 2021

@pszafer You've added cursor but I think you need to update the snapshots (yarn test -u) to update the snapshots?

@benjie benjie changed the title Expected SQL item bug fix with order by computed column fix(order): fix order by computed column SQL item bug May 26, 2021
@benjie benjie merged commit 0635ecb into graphile:v4 May 26, 2021
@pszafer
Copy link
Contributor Author

pszafer commented May 26, 2021

sorry I missed your message. I see it's merged already. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants