Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If an SQL error occurs in a mutation, previous data may still be rendered #75

Closed
benjie opened this issue Sep 19, 2017 · 0 comments
Closed
Labels
Milestone

Comments

@benjie
Copy link
Member

benjie commented Sep 19, 2017

For example if you perform createUser1, mutationThatProducesError, createUser2; the response may contain { createUser1: { id: 1, name: ... }, mutationThatProducesError: null, createUser2: null}; however the details of user 1 will have been rolled back by the mutation and thus should not be displayed to the user.

I suspect the solution is to use transaction checkpoints, because GraphQL will resolve each mutation field to completion before executing the next mutation field we don't need to worry about errors thrown in later mutations causing issues for resolve values of earlier mutation fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant