Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add foreign table to manyRelationByKeys call #80

Merged
merged 1 commit into from
Sep 25, 2017
Merged

add foreign table to manyRelationByKeys call #80

merged 1 commit into from
Sep 25, 2017

Conversation

mathroc
Copy link
Contributor

@mathroc mathroc commented Sep 23, 2017

closes #77

(not tested)

benjie
benjie requested changes Sep 23, 2017
View reviewed changes
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add these arguments to the inflector function too (prefix with underscores since they won’t be used) 🙏

@mathroc
Copy link
Contributor Author

mathroc commented Sep 24, 2017

done :)

@benjie benjie merged commit d2da240 into graphile:master Sep 25, 2017
@benjie
Copy link
Member

benjie commented Sep 25, 2017

🙏

@mathroc mathroc deleted the feat/manyRelationByKeys-args branch September 25, 2017 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjie benjie benjie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

needs foreign table info in inflector.manyRelationByKeys
2 participants
@mathroc @benjie