fix(graphql): don’t allow the use of cursors with offset

graphile · Oct 15, 2016 · 3159859 · 3159859
1 parent e081040
commit 3159859
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/graphql/schema/connection/createConnectionGqlField.ts b/src/graphql/schema/connection/createConnectionGqlField.ts
@@ -94,6 +94,10 @@ export default function createConnectionGqlField <TSource, TInput, TItemValue>(
       if (afterCursor && afterCursor.orderingName !== orderingName)
         throw new Error('`after` cursor can not be used for this `orderBy` value.')
 
+      // Don’t allow the use of cursors with `offset`.
+      if (beforeCursor != null && _offset != null || beforeCursor != null && _offset != null)
+        throw new Error('Cannot use `before`/`after` cursors with `offset`!')
+
       // Get our input.
       const input = config.getPaginatorInput(source, args)