Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade GraphiQL/GraphiQL Explorer #1377

Merged
merged 7 commits into from Nov 13, 2020
Merged

feat: upgrade GraphiQL/GraphiQL Explorer #1377

merged 7 commits into from Nov 13, 2020

Conversation

benjie
Copy link
Member

@benjie benjie commented Oct 30, 2020

Description

This is long overdue. Upgrade GraphiQL from 0.13.2 to 1.0.6; upgrade GraphiQL Explorer from 0.4.6 to 0.6.2.

Screenshot_20201030_170602

Fixes #1375

Performance impact

Unknown.

Security impact

None known.

TODO

  • Check it works with all the frameworks:
    • Watch mode
    • Subscriptions
    • Headers editing

@benjie
Copy link
Member Author

benjie commented Oct 30, 2020

I'd love to get this merged before we ship this: graphql/graphiql#1703

@benjie benjie marked this pull request as ready for review November 3, 2020 14:44
@benjie
Copy link
Member Author

benjie commented Nov 3, 2020

The above was merged; so once it's released we can update and then merge this 👍

@benjie
Copy link
Member Author

benjie commented Nov 11, 2020

I've tested this with each of the frameworks; it's good to merge 👍

@benjie
Copy link
Member Author

benjie commented Nov 13, 2020

Merging; we'll update again later when a GraphiQL release is ready with the above fix 👍

@benjie benjie merged commit 0152244 into v4 Nov 13, 2020
@benjie benjie deleted the upgrade-graphiql branch November 13, 2020 16:04
@benjie benjie restored the upgrade-graphiql branch November 13, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken GraphiQL CSS For "Explorer"
1 participant