fix(docker): remove GRAPHILE_TURBO #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dockerfile references Node 12; GRAPHILE_TURBO now requires Node 14
|
@benjie According to this file it is still v12: Cannot document what this actually does? I only found https://medium.com/graphile/how-i-made-postgraphile-faster-than-prisma-1-year-later-e6bf3a802f58 is still still correct? |
|
GRAPHILE_TURBO is a flag that opts you into optimisations only available in the latest release of Node.js (changes over time). It’s a moving target, hence it is an opt-in flag. Remove it and all should be well. |
|
I did not mean that I got the error, I wanted to point out that the error message is wrong |
|
Ah yeah; I have a PR for that: #1411 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dockerfile references Node 12; GRAPHILE_TURBO now requires Node 14
Performance impact
The Docker Hub image will run slower; npm build is unaffected.
Security impact
None.