feat(server): add server timeout configuration #623 #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjie
reviewed
May 3, 2018
src/postgraphile/cli.ts
Outdated
| @@ -422,6 +424,8 @@ if (noServer) { | |||
| const rawMiddleware = postgraphile(pgConfig, schemas, postgraphileOptions) | |||
| const middleware = pluginHook('cli:server:middleware', rawMiddleware, { options: postgraphileOptions }) | |||
| const server = createServer(middleware) | |||
| server.timeout = serverTimeout | |||
There was a problem hiding this comment.
I'm not super comfortable using a property access to timeout when there's a setter method setTimeout present; however I'm struggling to tell from the docs if they do the same thing or not:
Can you point to someone of authority stating that these are either equivalent, or that they're different and why you'd use one over the other?
There was a problem hiding this comment.
Hey @kronken, any idea regarding this? Are they different?
There was a problem hiding this comment.
Judging by the Node.js source they're equivalent:
benjie
approved these changes
Jul 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the ability to set timeout for socket connections.