Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(http): don't use LRU when queryCacheMaxSize too small #1312

Merged
merged 2 commits into from
Jul 22, 2020
Merged

fix(http): don't use LRU when queryCacheMaxSize too small #1312

merged 2 commits into from
Jul 22, 2020

Conversation

zacherkkila
Copy link

Fixes #1311

benjie
benjie approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; I've applied a few edits and this is now good to merge! 🙌

@benjie
Copy link
Member

benjie commented Jul 22, 2020

Restarting CI checks by closing and re-opening

@benjie benjie closed this Jul 22, 2020
@benjie benjie reopened this Jul 22, 2020
@benjie benjie closed this Jul 22, 2020
@benjie benjie reopened this Jul 22, 2020
@benjie benjie changed the title Stop LRU creation when queryCacheMaxSize is 0 fix(http): don't use LRU when queryCacheMaxSize too small Jul 22, 2020
@benjie benjie merged commit 82c0a4c into graphile:v4 Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjie benjie benjie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting queryCacheMaxSize to 0 throws an error
2 participants
@zacherkkila @benjie