Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Might want to consider optimizing for speed instead of optimizing for code size #32

Closed
protheory8 opened this issue Mar 19, 2021 · 5 comments

Comments

@protheory8
Copy link
Contributor

Code size optimizations may slow down the code: rustwasm/wasm-pack-template#27

@Keavon
Copy link
Member

Keavon commented Mar 19, 2021

Let's optimize for development speed (i.e. minimal compilation/build time) until we get to the part where we are performance constrained. Release builds should probably prefer performance over file size within reason, but realize it's still being served by a CDN to random visitors who will have to load it all in their browser.

Please set the build options (for dev and release) as you see fit according to these goals.

@protheory8
Copy link
Contributor Author

Left opt-level on s for now.

@Keavon
Copy link
Member

Keavon commented Mar 22, 2021

Is this resolved for now? Can we close it?

@protheory8
Copy link
Contributor Author

We ended up with optimizing for code size instead of speed so not really, but we can close it anyway.

@Keavon
Copy link
Member

Keavon commented Mar 23, 2021

Ok. Feel free to reopen this issue in the future if it becomes time to reevaluate that decision.

@Keavon Keavon closed this as completed Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants