Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate wasm-pack from build system #74

Closed
Keavon opened this issue Apr 14, 2021 · 1 comment
Closed

Eliminate wasm-pack from build system #74

Keavon opened this issue Apr 14, 2021 · 1 comment
Labels
Good First Issue Good for newcomers Help Wanted Extra attention is needed Infrastructure Build systems and CI

Comments

@Keavon
Copy link
Member

Keavon commented Apr 14, 2021

We are using wasm-pack and wasm-pack-plugin as dev dependencies. But we really should only need wasm-bindgen. The fewer dependencies, the better— especially because wasm-pack is apparently unmaintained and has a high-severity security vulnerability from a sub-dependency and upgrading to the patched dependency version has gone unfixed for nearly half a year. We do not need all the features of wasm-pack, it simply rolls together the separate parts of our Vue (through webpack) and wasm-bindgen build process. Let's fix the security problem and work towards removing non-vital dependencies.

@Keavon Keavon added Available Good First Issue Good for newcomers Help Wanted Extra attention is needed Infrastructure Build systems and CI labels Apr 14, 2021
@Keavon
Copy link
Member Author

Keavon commented Apr 15, 2021

After some research and attempts to figure this out, I've concluded that wasm-pack is truly the officially recommended approach and going without wasm-pack is likely to cause more problems than it solves. Hopefully somebody can fix the security vulnerability and otherwise continue maintaining it. I'll close this issue for now, but I'm still happy to accept pull requests to solve this anybody is familiar enough with the wasm-bindgen and webpack build systems to figure it out robustly. Another great use of time would be just going and fixing the security issue.

@Keavon Keavon closed this as completed Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for newcomers Help Wanted Extra attention is needed Infrastructure Build systems and CI
Projects
None yet
Development

No branches or pull requests

1 participant