Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PISA examples self-contained #404

Closed
asogaard opened this issue Jan 31, 2023 · 2 comments · Fixed by #471
Closed

Make PISA examples self-contained #404

asogaard opened this issue Jan 31, 2023 · 2 comments · Fixed by #471
Assignees
Labels
feature New feature or request

Comments

@asogaard
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
With #378 most examples scripts are self-contained, i.e. referring only to files that come bundled with the repo. The only exception is the PISA ones.

Describe the solution you'd like
It would be nice if all the example scripts we provide, including the PISA ones, could be run out of the box, provided of course that the necessary packages are installed. This is also requested here: openjournals/joss-reviews#4971 (comment).

Describe alternatives you've considered
If we want to keep our examples self-contained, the alternative would be to not provide examples on the interface with PISA, but I think this would be a shame.

@RasmusOrsoe
Copy link
Collaborator

@asogaard as discussed with you and @philippeller , we cannot do this unless we have significantly higher statistics in our public data. (Running a minimizer on ~5 events wont work). So I think we can close this.

@asogaard
Copy link
Collaborator Author

Closing in favour of #428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants