Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AllocationMonitor #35

Merged
merged 5 commits into from
Aug 22, 2023
Merged

feat: AllocationMonitor #35

merged 5 commits into from
Aug 22, 2023

Conversation

aasseman
Copy link
Collaborator

@aasseman aasseman commented Aug 17, 2023

It doesn't have the Attestation bits yet.
Should behave like the one in indexer-service.

Fixes #25

Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
To allow auto desarialization from either hex of multihash

Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
@aasseman aasseman requested a review from hopeyen August 17, 2023 18:31
@aasseman aasseman self-assigned this Aug 17, 2023
@aasseman aasseman marked this pull request as draft August 17, 2023 18:32
Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
@aasseman aasseman marked this pull request as ready for review August 17, 2023 18:37
Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
@github-actions
Copy link

Pull Request Test Coverage Report for Build 5897849065

  • 143 of 236 (60.59%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+6.7%) to 21.664%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/src/config.rs 0 1 0.0%
service/src/main.rs 0 7 0.0%
service/src/allocation_monitor.rs 109 194 56.19%
Totals Coverage Status
Change from base Build 5893719355: 6.7%
Covered Lines: 349
Relevant Lines: 1611

💛 - Coveralls

Copy link
Collaborator

@hopeyen hopeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing stuff!

@aasseman aasseman merged commit 86105e5 into main Aug 22, 2023
5 checks passed
@aasseman aasseman deleted the aasseman/allocation_monitor branch August 22, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: allocation monitor
2 participants