Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize NetworkSubgraph into SubgraphClient #72

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Generalize NetworkSubgraph into SubgraphClient #72

merged 1 commit into from
Oct 17, 2023

Conversation

Jannis
Copy link
Collaborator

@Jannis Jannis commented Oct 17, 2023 •
edited
Loading

This way we can also it for the escrow subgraph and others that we may need in the future.

This is based on #71 and will need to be rebased when that has been merged.

@aasseman aasseman added size:large Large type:refactor Changes not visible to users size:medium Medium p1 High priority and removed size:large Large labels Oct 17, 2023
aasseman
aasseman previously approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@aasseman aasseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Jannis
refactor: generalize network subgraph into a subgraph client
39902a2 
This way we can also use it for the escrow subgraph and others that we may need
in the future.
@Jannis Jannis dismissed aasseman’s stale review October 17, 2023 22:56

The merge-base changed after approval.

@github-actions
Copy link

Pull Request Test Coverage Report for Build 6553765794

  • 36 of 56 (64.29%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 41.886%
Changes Missing Coverage Covered Lines Changed/Added Lines %
service/src/server/mod.rs 0 1 0.0%
common/src/subgraph_client.rs 19 24 79.17%
service/src/main.rs 0 14 0.0%
Totals Coverage Status
Change from base Build 6553756582: -0.04%
Covered Lines: 986
Relevant Lines: 2354
💛 - Coveralls

@Jannis Jannis merged commit a0b1c87 into main Oct 17, 2023
5 checks passed
@Jannis Jannis deleted the jannis/subgraph-client branch October 17, 2023 23:06
@Jannis Jannis restored the jannis/subgraph-client branch October 25, 2023 12:37
@Jannis Jannis deleted the jannis/subgraph-client branch October 25, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aasseman aasseman aasseman approved these changes

@hopeyen hopeyen Awaiting requested review from hopeyen

Assignees

@Jannis Jannis

Labels
p1 High priority size:medium Medium type:refactor Changes not visible to users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jannis @aasseman