Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate GraphQL schema when loading subgraphs #149

Merged
merged 2 commits into from
Oct 16, 2018
Merged

Validate GraphQL schema when loading subgraphs #149

merged 2 commits into from
Oct 16, 2018

Conversation

Jannis
Copy link
Contributor

@Jannis Jannis commented Oct 10, 2018

This adds the following validation steps to subgraph loading:

  1. Validate that the GraphQL schema can be loaded / read from its file.
  2. Validate that the GraphQL schema can be parsed (i.e. is valid GraphQL).
  3. Validate that all types have the @entity directive.

@Jannis Jannis self-assigned this Oct 10, 2018
@Jannis Jannis requested a review from a team October 10, 2018 10:52
@ghost ghost added the pending review label Oct 10, 2018
@Jannis Jannis mentioned this pull request Oct 10, 2018
Open
14 tasks
@Jannis Jannis force-pushed the jannis/subgraph-schema-validation branch from 6f314ae to 7ef2a33 Compare October 11, 2018 12:00
@Jannis Jannis force-pushed the jannis/subgraph-schema-validation branch from 7ef2a33 to 75e51fb Compare October 12, 2018 06:33
@Jannis Jannis merged commit 143c21c into master Oct 16, 2018
@ghost ghost removed the pending review label Oct 16, 2018
@Jannis Jannis deleted the jannis/subgraph-schema-validation branch October 16, 2018 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoyvens leoyvens leoyvens approved these changes

Assignees

@Jannis Jannis

Labels
area/cli new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jannis @leoyvens